[GitHub] [geode-benchmarks] pivotal-jbarrett commented on a change in pull request #150: Adds Redis benchmarks.

[GitBox]

pivotal-jbarrett commented on a change in pull request #150:
URL: https://github.com/apache/geode-benchmarks/pull/150#discussion_r632588751



##########
File path: 
geode-benchmarks/src/main/java/org/apache/geode/benchmark/tasks/StartServer.java
##########
@@ -49,20 +51,41 @@ public void run(TestContext context) throws Exception {
 
     Properties properties = serverProperties();
 
+    final CacheFactory cacheFactory = new CacheFactory(properties);
+    configureCacheFactory(cacheFactory, context);
+    final InternalCache cache = (InternalCache) cacheFactory.create();
+
+    final CacheServer cacheServer = 
configureCacheServer(cache.addCacheServer(), context);
+    if (null != cacheServer) {
+      cacheServer.start();
+    }
+
+    configureCache(cache, context);
+
+    context.setAttribute(SERVER_CACHE, cache);
+  }
+
+  protected void configureCache(final InternalCache cache, final TestContext 
context) {}

Review comment:
       Yup, in older revisions this directly manipulated the 
`GeodeRedisService` but that has been replaced with system properties. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org