pivotal-jbarrett commented on a change in pull request #150: URL: https://github.com/apache/geode-benchmarks/pull/150#discussion_r632634162
########## File path: geode-benchmarks/src/main/java/org/apache/geode/benchmark/tasks/redis/HsetRedisTask.java ########## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.geode.benchmark.tasks.redis; + + +import java.io.Serializable; +import java.util.Map; + +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; +import org.yardstickframework.BenchmarkConfiguration; +import org.yardstickframework.BenchmarkDriverAdapter; + +import org.apache.geode.benchmark.LongRange; + +public class HsetRedisTask extends BenchmarkDriverAdapter implements Serializable { + private static final Logger logger = LoggerFactory.getLogger(HsetRedisTask.class); + + private final RedisClientManager redisClientManager; + private final LongRange keyRange; + + private transient LongStringCache keyCache; + private transient RedisClient redisClient; + + public HsetRedisTask(final RedisClientManager redisClientManager, final LongRange keyRange) { + logger.info("Initialized: keyRange={}", keyRange); + this.redisClientManager = redisClientManager; + this.keyRange = keyRange; + } + + @Override + public void setUp(final BenchmarkConfiguration cfg) throws Exception { + super.setUp(cfg); + + keyCache = new LongStringCache(keyRange); + redisClient = redisClientManager.get(); + } + + @Override + public boolean test(final Map<Object, Object> ctx) throws Exception { + final long k = keyRange.random(); + final String key = keyCache.valueOf(k / 1000); + final String field = keyCache.valueOf(k % 1000); + final String value = keyCache.valueOf(k); + redisClient.hset(key, field, value); Review comment: Nothing in the client or the server looks at the identity of the value to avoid repeated sets. From the client and server perspective it is always a new value. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
