pivotal-jbarrett commented on a change in pull request #150: URL: https://github.com/apache/geode-benchmarks/pull/150#discussion_r632586277
########## File path: geode-benchmarks/src/main/java/org/apache/geode/benchmark/tasks/GetStringTask.java ########## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.geode.benchmark.tasks; + +import static java.lang.String.valueOf; +import static org.junit.jupiter.api.Assertions.assertEquals; + +import java.io.Serializable; +import java.util.Map; + +import org.yardstickframework.BenchmarkConfiguration; +import org.yardstickframework.BenchmarkDriverAdapter; + +import org.apache.geode.benchmark.LongRange; +import org.apache.geode.cache.Cache; +import org.apache.geode.cache.CacheFactory; +import org.apache.geode.cache.Region; + +/** + * Task workload to perform get operations on keys within 0 + * and the keyRange (exclusive) + */ +public class GetStringTask extends BenchmarkDriverAdapter implements Serializable { + + private final LongRange keyRange; + private final boolean validate; + + private Region<String, String> region; + private long offset; + private String[] keys; + + public GetStringTask(final LongRange keyRange, final boolean validate) { + this.keyRange = keyRange; + this.validate = validate; + } + + @Override + public void setUp(BenchmarkConfiguration cfg) throws Exception { + super.setUp(cfg); + + final Cache cache = CacheFactory.getAnyInstance(); + region = cache.getRegion("region"); + + offset = keyRange.getMin(); + keys = new String[(int) (keyRange.getMax() - offset)]; + keyRange.forEach(i -> keys[(int) i] = valueOf(i)); Review comment: What do you hope to achieve with consistent key/value sizes? Given the selection of keys/values is uniformly distributed the variance between runs should be uniform. We could go with fixed sizes but I am not sure that will make anything more consistent. Perhaps a good experiment after the PR for someone. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
