jinmeiliao commented on a change in pull request #6835:
URL: https://github.com/apache/geode/pull/6835#discussion_r709341414
##########
File path:
geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionTest.java
##########
@@ -57,25 +67,37 @@
private AcceptorImpl acceptor;
private Message requestMessage;
private ServerSideHandshake handshake;
+ private SecurityService securityService;
private ServerConnection serverConnection;
+ private Command command;
+ private InetAddress inetAddress;
+ private Socket socket;
+ private InternalCacheForClientAccess cache;
+ private CachedRegionHelper cachedRegionHelper;
+ private InternalDistributedSystem internalDistributedSystem;
+ private DistributionManager distributionManager;
+ private ThreadsMonitoring threadsMonitoring;
Review comment:
I make it a habit to always declare them as class variables just in case
any future tests would use them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
