DonalEvans commented on a change in pull request #6835:
URL: https://github.com/apache/geode/pull/6835#discussion_r709440767
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnection.java
##########
@@ -894,6 +876,50 @@ void doNormalMessage() {
}
}
+ ThreadState bindSubject(Command command) {
+ if (!securityService.isIntegratedSecurity()) {
+ return null;
+ }
+
+ if (communicationMode.isWAN()) {
+ return null;
+ }
+
+ if (command instanceof PutUserCredentials) {
+ return null;
+ }
+
+ if (isInternalMessage(requestMessage,
allowInternalMessagesWithoutCredentials)) {
+ return null;
+ }
+
+ long uniqueId = getUniqueId();
+ String messageType =
MessageType.getString(requestMessage.getMessageType());
+ if (uniqueId == 0 || uniqueId == -1) {
+ logger.debug("No unique ID yet. {}, {}", messageType, getName());
Review comment:
I just checked and it seems that wrapping the log statement in that
check has no effect on the behaviour. I guess that it was necessary at one
point, because I see that pattern all over the place, but it seems that it's
fine not to do it here. I learned something new today!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
