jinmeiliao commented on a change in pull request #6835:
URL: https://github.com/apache/geode/pull/6835#discussion_r709390386
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnection.java
##########
@@ -894,6 +876,50 @@ void doNormalMessage() {
}
}
+ ThreadState bindSubject(Command command) {
+ if (!securityService.isIntegratedSecurity()) {
+ return null;
+ }
+
+ if (communicationMode.isWAN()) {
+ return null;
+ }
+
+ if (command instanceof PutUserCredentials) {
+ return null;
+ }
+
+ if (isInternalMessage(requestMessage,
allowInternalMessagesWithoutCredentials)) {
+ return null;
+ }
+
+ long uniqueId = getUniqueId();
+ String messageType =
MessageType.getString(requestMessage.getMessageType());
+ if (uniqueId == 0 || uniqueId == -1) {
+ logger.debug("No unique ID yet. {}, {}", messageType, getName());
Review comment:
always not sure what's the benefit of that, I was just following what
was done before. I hate to clutter up the code with more `if` statements if
it's not necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
