jinmeiliao commented on a change in pull request #6835: URL: https://github.com/apache/geode/pull/6835#discussion_r709392947
########## File path: geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/CacheClientProxyTest.java ########## @@ -0,0 +1,123 @@ +/* + * + * Licensed to the Apache Software Foundation (ASF) under one or more contributor license + * agreements. See the NOTICE file distributed with this work for additional information regarding + * copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the License. You may obtain a + * copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software distributed under the License + * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express + * or implied. See the License for the specific language governing permissions and limitations under + * the License. + * + */ + +package org.apache.geode.internal.cache.tier.sockets; + +import static org.assertj.core.api.Assertions.assertThat; +import static org.mockito.ArgumentMatchers.any; +import static org.mockito.ArgumentMatchers.anyBoolean; +import static org.mockito.Mockito.mock; +import static org.mockito.Mockito.never; +import static org.mockito.Mockito.spy; +import static org.mockito.Mockito.verify; +import static org.mockito.Mockito.when; + +import java.net.InetAddress; +import java.net.Socket; + +import org.apache.shiro.subject.Subject; +import org.junit.Before; +import org.junit.Test; + +import org.apache.geode.StatisticsFactory; +import org.apache.geode.internal.cache.Conflatable; +import org.apache.geode.internal.cache.InternalCache; +import org.apache.geode.internal.cache.tier.sockets.CacheClientProxy.CacheClientProxyStatsFactory; +import org.apache.geode.internal.cache.tier.sockets.CacheClientProxy.MessageDispatcherFactory; +import org.apache.geode.internal.security.SecurityService; +import org.apache.geode.internal.serialization.KnownVersion; +import org.apache.geode.internal.statistics.StatisticsClock; + +public class CacheClientProxyTest { + private CacheClientProxy proxy; + private CacheClientNotifier notifier; + private Socket socket; + private ClientProxyMembershipID id; + private KnownVersion version; + private SecurityService securityService; + private Subject subject; + private StatisticsClock clock; + private InternalCache cache; + private StatisticsFactory statsFactory; + private CacheClientProxyStatsFactory proxyStatsFactory; + private MessageDispatcherFactory dispatcherFactory; + private InetAddress inetAddress; + private CacheServerStats stats; Review comment: Same as my other junit tests, I prefer to put them as class variable for future tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
