jdaugherty commented on code in PR #15199:
URL: https://github.com/apache/grails-core/pull/15199#discussion_r2486302097
##########
grails-forge/grails-forge-core/src/main/java/org/grails/forge/io/ZipOutputHandler.java:
##########
@@ -78,10 +83,19 @@ public boolean exists(String path) {
@Override
public void write(String path, Template contents) throws IOException {
- ZipArchiveEntry zipEntry = new ZipArchiveEntry(directory != null ?
StringUtils.prependUri(directory, path) : path);
- if (contents.isExecutable()) {
- zipEntry.setUnixMode(UnixStat.FILE_FLAG | 0755);
- }
+ String entryName = (directory != null ?
StringUtils.prependUri(directory, path) : path);
+ FileTime lastModified = FileTime.from(Instant.now());
Review Comment:
If source date epoch is set can we parse that time instead? now can be the
default otherwise ...
##########
grails-forge/grails-forge-core/src/main/java/org/grails/forge/io/ZipOutputHandler.java:
##########
@@ -92,4 +106,29 @@ public void close() throws IOException {
zipOutputStream.finish();
zipOutputStream.close();
}
+
+ private void createParentDirs(String entryName, FileTime lastModified)
throws IOException {
+ int slash = entryName.lastIndexOf('/');
Review Comment:
Do zip files not use the system file separator?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
