jdaugherty commented on code in PR #15199:
URL: https://github.com/apache/grails-core/pull/15199#discussion_r2487340792
##########
grails-forge/grails-forge-core/src/main/java/org/grails/forge/io/ZipOutputHandler.java:
##########
@@ -78,10 +83,19 @@ public boolean exists(String path) {
@Override
public void write(String path, Template contents) throws IOException {
- ZipArchiveEntry zipEntry = new ZipArchiveEntry(directory != null ?
StringUtils.prependUri(directory, path) : path);
- if (contents.isExecutable()) {
- zipEntry.setUnixMode(UnixStat.FILE_FLAG | 0755);
- }
+ String entryName = (directory != null ?
StringUtils.prependUri(directory, path) : path);
+ FileTime lastModified = FileTime.from(Instant.now());
Review Comment:
It's really just for best practice - any build we publish should be
reproducible. Before your change, it tried to write out a consistent time, and
after it's going to write out .now() for every file. I can see the argument
that the container won't be published, but core is and others could use it.
I also think longer term, we should stage forge so we can make it easier to
test staging / make sure it works - but I think we have higher priorities right
now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
