jdaugherty commented on code in PR #15199:
URL: https://github.com/apache/grails-core/pull/15199#discussion_r2490829004
##########
grails-forge/grails-forge-core/src/main/java/org/grails/forge/io/ZipOutputHandler.java:
##########
@@ -78,10 +83,19 @@ public boolean exists(String path) {
@Override
public void write(String path, Template contents) throws IOException {
- ZipArchiveEntry zipEntry = new ZipArchiveEntry(directory != null ?
StringUtils.prependUri(directory, path) : path);
- if (contents.isExecutable()) {
- zipEntry.setUnixMode(UnixStat.FILE_FLAG | 0755);
- }
+ String entryName = (directory != null ?
StringUtils.prependUri(directory, path) : path);
+ FileTime lastModified = FileTime.from(Instant.now());
Review Comment:
I spoke to @jamesfredley more about this too. Longer term, I want to
publish forge to a staging area that we can also test as part of the vote
process - to ensure it's not broken. We'll want this reproducible for that
testing too. @matrei if you still feel strongly about this, let's discuss in
the weekly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
