matrei commented on code in PR #15199:
URL: https://github.com/apache/grails-core/pull/15199#discussion_r2486452261
##########
grails-forge/grails-forge-core/src/main/java/org/grails/forge/io/ZipOutputHandler.java:
##########
@@ -78,10 +83,19 @@ public boolean exists(String path) {
@Override
public void write(String path, Template contents) throws IOException {
- ZipArchiveEntry zipEntry = new ZipArchiveEntry(directory != null ?
StringUtils.prependUri(directory, path) : path);
- if (contents.isExecutable()) {
- zipEntry.setUnixMode(UnixStat.FILE_FLAG | 0755);
- }
+ String entryName = (directory != null ?
StringUtils.prependUri(directory, path) : path);
+ FileTime lastModified = FileTime.from(Instant.now());
Review Comment:
The only other place where we reference `System.getenv('SOURCE_DATE_EPOCH')`
in production code is in `PropertyFileUtils`.
I can add it if you think it would be useable, I just want to understand
why, and if it's really going to be used?
(`ZipOutputHandler` is only used in `ZipCreateController` which is in
`grails-forge-api`).
In that case, should I also add it to `FileSystemOutputHandler`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
