Github user jwagenleitner commented on the pull request:
https://github.com/apache/groovy/commit/584d4d405061a08c317ea1297c2833f93445bcb7#commitcomment-18561203
In src/spec/test/SyntaxTest.groovy:
In src/spec/test/SyntaxTest.groovy on line 169:
Thanks for pointing that out. I don't see much use in documenting these
invalid cases so agree that the tags should be removed.
That brings up another question, if they aren't going to be used in
asciidoc then they probably aren't good candidates to live in a spec test?
Would [gls.syntax.NumberLiteralTest]
(https://github.com/apache/groovy/blob/584d4d405061a08c317ea1297c2833f93445bcb7/src/test/gls/syntax/NumberLiteralTest.groovy)
(but I'm not sure what's appropriate for the `gls.` package) or a separate
test class under `groovy.bugs` be a better location or do you think this class
is fine if the tags are removed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
