Github user jwagenleitner commented on the pull request:
https://github.com/apache/groovy/commit/9be5459c906ba106f235d40ebe0f25b7193a0467#commitcomment-18975680
In src/main/org/apache/groovy/metaclass/Realm.java:
In src/main/org/apache/groovy/metaclass/Realm.java on line 43:
>as for the header... looks like we have a misconfiguration in our build
then, since I am using what is defined by the gradle build.
I fixed up the header for Idea projects in the build a while back, not sure
about the Eclipse settings. But to pick up the new Idea settings would
probably require a `./gradlew cleanIdea jar idea`.
>As for the missing <?>, yeah, that can be added. Frankly it is not of any
real use, but well, doesn´t hurt either.
I hesitated to bring that up as I don't want to look like I'm nit-picking.
:smile: Just thought that in new code it's good to not use raw types if it can
be helped even if in most places it's just a Object or a wildcard. And I missed
the ClassValue on the rhs was missing the `<MetaClass>` type argument.
>Realm should be more understood as a replacement for MetaClassRegistry.
ClassInfo and MetaClass I want to merge into one structure.
Ah, that makes sense, especially after re-reading your post [Thoughts about
the new meta class system MOP 2]
(http://blackdragsview.blogspot.com/2015/03/thoughts-about-new-meta-class-system.html).
I think favoring immutability and heading away from inheritance towards
composition will work nicely and would hopefully make keeping method/property
resolution strategies more in sync.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
