korlov42 commented on code in PR #944:
URL: https://github.com/apache/ignite-3/pull/944#discussion_r928830956
##########
modules/schema/src/main/java/org/apache/ignite/internal/schema/definition/builder/ColumnDefinitionBuilderImpl.java:
##########
@@ -78,6 +79,9 @@ public ColumnDefinitionBuilderImpl withHints(Map<String,
String> hints) {
/** {@inheritDoc} */
@Override
public ColumnDefinition build() {
- return new ColumnDefinitionImpl(colName, colType, nullable,
defValExpr);
+ var defaultSupp = defValExpr == null
Review Comment:
> should we assert that nullable false for defValExpr = null?
I don't think so. `nullable==false && defValExpr==null` means that the user
MUST provide value for every such column in insert tuple.
> May be need distinguish explicit and implicit null for the case
Could you please elaborate on why do you think this is important to
distinguish between implicit and explicit null?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
