korlov42 commented on code in PR #944:
URL: https://github.com/apache/ignite-3/pull/944#discussion_r928834280
##########
modules/schema/src/test/java/org/apache/ignite/internal/schema/configuration/SchemaConfigurationConverterTest.java:
##########
@@ -332,32 +345,11 @@ private static Iterable<DefaultValueArg>
generateTestArguments() {
for (var entry : DEFAULT_VALUES_TO_TEST.entrySet()) {
for (var defaultValue : entry.getValue()) {
- if (skipValue(entry.getKey(), defaultValue)) {
- continue;
- }
-
paramList.add(
new DefaultValueArg(specToType(entry.getKey()),
adjust(defaultValue))
);
}
}
return paramList;
}
-
- // TODO: IGNITE-17370 remove this
Review Comment:
Currently the mentioned issue is still actual in master, hence we need to
close this after current patch will be merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
