korlov42 commented on code in PR #944: URL: https://github.com/apache/ignite-3/pull/944#discussion_r928892654
########## modules/schema/src/main/java/org/apache/ignite/internal/schema/DefaultValueGenerator.java: ########## @@ -0,0 +1,60 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.schema; + +import java.lang.reflect.Method; +import java.util.UUID; + +/** + * Enumeration of all supported value generators that could be used as a default value provider + * (i.e. could be specified as a default in column definition). + */ +public enum DefaultValueGenerator { + /** Generator that generates random UUID string. */ + GEN_RANDOM_UUID("genRandomUuid"); + + private final Method method; + + DefaultValueGenerator(String methodName) { + try { + this.method = DefaultValueGenerator.class.getMethod(methodName); Review Comment: I've prepared a simple benchmark, and here is result: ``` Benchmark Mode Cnt Score Error Units GeneratorBenchmark.methodHandler avgt 10 351.173 ± 7.643 ns/op GeneratorBenchmark.reflection avgt 10 350.095 ± 10.908 ns/op ``` The code of the benchmark is here: ``` public enum DefaultValueGenerator { /** Generator that generates random UUID string. */ GEN_RANDOM_UUID("genRandomUuid"); public final Method method; public final MethodHandle methodHandle; DefaultValueGenerator(String methodName) { try { this.method = DefaultValueGenerator.class.getMethod(methodName); this.methodHandle = MethodHandles.lookup().findStatic( DefaultValueGenerator.class, methodName, MethodType.methodType(String.class) ); } catch (NoSuchMethodException | IllegalAccessException e) { throw new IllegalStateException(e); } } /** * Returns next value. * * @param <T> Param to cast value to. * @return Next value. */ @SuppressWarnings("unchecked") public <T> T nextReflection() { try { return (T) method.invoke(method.getDeclaringClass()); } catch (Exception e) { throw new IllegalStateException(e); } } /** * Returns next value. * * @param <T> Param to cast value to. * @return Next value. */ @SuppressWarnings("unchecked") public <T> T nextMethodHandle() { try { return (T) methodHandle.invoke(); } catch (Throwable e) { throw new IllegalStateException(e); } } /** Returns random UUID string. */ public static String genRandomUuid() { return UUID.randomUUID().toString(); } } @State(Scope.Benchmark) @BenchmarkMode(Mode.AverageTime) @OutputTimeUnit(TimeUnit.NANOSECONDS) public class GeneratorBenchmark { @Benchmark public String reflection() { return DefaultValueGenerator.GEN_RANDOM_UUID.nextReflection(); } @Benchmark public String methodHandler() { return DefaultValueGenerator.GEN_RANDOM_UUID.nextMethodHandle(); } public static void main(String[] args) throws RunnerException { DefaultValueGenerator.GEN_RANDOM_UUID.nextMethodHandle(); Options opt = new OptionsBuilder() .include(GeneratorBenchmark.class.getSimpleName()) .warmupIterations(20) .warmupTime(TimeValue.seconds(1)) .measurementIterations(10) .measurementTime(TimeValue.seconds(1)) .forks(1) .build(); new Runner(opt).run(); } } ``` Looks like there is no difference actually. Could you please verify the results? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
