korlov42 commented on code in PR #944:
URL: https://github.com/apache/ignite-3/pull/944#discussion_r928968990
##########
modules/schema/src/main/java/org/apache/ignite/internal/schema/Column.java:
##########
@@ -30,7 +29,7 @@
*/
public class Column {
/** Default "default value supplier". */
- private static final Supplier<Object> NULL_SUPPLIER = () -> null;
+ private static final DefaultValueProvider NULL_SUPPLIER =
DefaultValueProvider.constantProvider(null);
Review Comment:
done
##########
modules/api/src/main/java/org/apache/ignite/schema/definition/ColumnDefinition.java:
##########
@@ -43,10 +43,9 @@ public interface ColumnDefinition {
boolean nullable();
/**
- * Returns column default value expression.
+ * Returns default value definition.
*
- * @return Default column value expression.
+ * @return Default value definition.
*/
- //TODO: IGNITE-14479: Rename to defaultValueExpr or allow constants? How
to distinct expression from string constant???
- Object defaultValue();
+ DefaultValueDefinition defaultValueDefinition();
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
