Flaugh24 commented on code in PR #2684:
URL: https://github.com/apache/ignite-3/pull/2684#discussion_r1360506609
##########
modules/rest/src/main/java/org/apache/ignite/internal/rest/cluster/ClusterManagementController.java:
##########
@@ -84,27 +74,15 @@ public CompletableFuture<Void> init(@Body InitCommand
initCommand) {
initCommand.cmgNodes());
}
- return validateConfiguration(initCommand.clusterConfiguration())
- .thenCompose(ignored -> clusterInitializer.initCluster(
- initCommand.metaStorageNodes(),
- initCommand.cmgNodes(),
- initCommand.clusterName(),
- initCommand.clusterConfiguration()
- ))
- .exceptionally(ex -> {
- throw mapException(ex);
- });
- }
-
- private CompletableFuture<Void> validateConfiguration(@Nullable String
configuration) {
- if (configuration != null) {
- List<ValidationIssue> validationIssues =
clusterCfgValidator.validateHocon(configuration);
- if (!validationIssues.isEmpty()) {
- return CompletableFuture.failedFuture(new
ConfigurationValidationException(validationIssues));
- }
- }
-
- return CompletableFuture.completedFuture(null);
+ //return validateConfiguration(initCommand.clusterConfiguration())
+ return clusterInitializer.initCluster(
+ initCommand.metaStorageNodes(),
+ initCommand.cmgNodes(),
+ initCommand.clusterName(),
+ initCommand.clusterConfiguration()
+ ).exceptionally(ex -> {
+ throw mapException(ex);
Review Comment:
org.apache.ignite.internal.rest.ItNotInitializedClusterRestTest#initClusterWithInvalidConfig
But I'm not sure that there is a mapping for Java API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
