Flaugh24 commented on code in PR #2684:
URL: https://github.com/apache/ignite-3/pull/2684#discussion_r1361714402
##########
modules/cluster-management/src/main/java/org/apache/ignite/internal/cluster/management/ClusterInitializer.java:
##########
@@ -264,18 +254,16 @@ private static List<ClusterNode>
resolveNodes(ClusterService clusterService, Col
}
- private CompletableFuture<String>
setDefaultsToClusterConfiguration(@Nullable String hocon) {
- return configurationDefaultsSetter.setDefaults(hocon == null ? "" :
hocon);
+ private String patchClusterConfigurationWithDefaults(@Nullable String
hocon) {
+ return configurationDefaultsPatcher.patchWithDefaults(hocon == null ?
"" : hocon);
Review Comment:
We convert it once to a tree and once to back.
It could but I think it's quite weird to patch `null`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
