Flaugh24 commented on code in PR #2684:
URL: https://github.com/apache/ignite-3/pull/2684#discussion_r1361716390


##########
modules/cli/src/integrationTest/java/org/apache/ignite/internal/rest/ItGeneratedRestClientTest.java:
##########
@@ -287,25 +287,14 @@ void updateClusterConfigurationWithInvalidParam() throws 
JsonProcessingException
         ApiException thrown = assertThrows(
                 ApiException.class,
                 () -> clusterConfigurationApi.updateClusterConfiguration("{\n"
-                        + "    \"security\": {\n"
-                        + "        \"authentication\": {\n"
-                        + "            \"enabled\": true,\n"
-                        + "            \"providers\": [\n"
-                        + "                {\n"
-                        + "                    \"name\": \"basic\",\n"
-                        + "                    \"type\": \"basic\",\n"
-                        + "                    \"username\": \"\",\n"
-                        + "                    \"password\": \"\"\n"
-                        + "                }\n"
-                        + "            ]\n"
-                        + "        }\n"
-                        + "    }\n"
+                        + "    security.enabled:true, \n"
+                        + "    security.authentication.providers:null\n"
                         + "}")
         );
 
         Problem problem = objectMapper.readValue(thrown.getResponseBody(), 
Problem.class);
         assertThat(problem.getStatus(), equalTo(400));
-        assertThat(problem.getInvalidParams(), hasSize(2));
+        assertThat(problem.getInvalidParams(), hasSize(1));

Review Comment:
   Actually, it tests the REST client can handle the response. I'm not sure 
that we should check the message here. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to