PakhomovAlexander commented on code in PR #2684: URL: https://github.com/apache/ignite-3/pull/2684#discussion_r1362296455
########## modules/configuration/src/test/java/org/apache/ignite/internal/configuration/ConfigurationDefaultsPatcherImplTest.java: ########## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.configuration; + +import static org.hamcrest.MatcherAssert.assertThat; +import static org.hamcrest.Matchers.equalTo; + +import org.junit.jupiter.api.AfterAll; +import org.junit.jupiter.api.BeforeAll; +import org.junit.jupiter.api.Test; + +class ConfigurationDefaultsPatcherImplTest { + private static final TestConfigurationModule MODULE = new TestConfigurationModule(); + + private static ConfigurationTreeGenerator generator; + + private static ConfigurationDefaultsPatcherImpl patcher; + + @BeforeAll + static void beforeAll() { + generator = new ConfigurationTreeGenerator( + MODULE.rootKeys(), + MODULE.schemaExtensions(), + MODULE.polymorphicSchemaExtensions() + ); + patcher = new ConfigurationDefaultsPatcherImpl( + MODULE, + generator + ); + } + + @AfterAll + static void afterAll() { + generator.close(); + } + + @Test + void patchedHoconDoesNotContainNullValues() { + String patchedHocon = patcher.patchWithDefaults(""); Review Comment: I expect an empty hocon being patched to... empty hocon. That is absolutely implicit that you pass an empty string and get some hocon configuration. The name of the method `patchWithDefaults` and javadocs says nothing about it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
