Flaugh24 commented on PR #2684: URL: https://github.com/apache/ignite-3/pull/2684#issuecomment-1767599396
> Two concerns here: > > 1. It seems like the goal of the ticket was to create Ignite/Ignite user if there is no such and move the `enabled` configuration up to the `security` level. But I see significant changes in the configuration framework and absolutely nothing is said about them. Why do we have to adjust a module interface? Shall I add some code to my own configuration module if I want to have some defaults? Devnotes to the configuration module were also missed as well as a commit message with an explanation of why we've made such changes. > 2. Maybe I've missed something but could you answer my question: Do we set the Ignite/Ignite user in case `security.enabled=false`? 1. We don't have the ability to set dynamic defaults in the current implementation of configuration. Moreover, we don't have the ability to set a default value for `NamedConfigValue` at all. Yes, you should add the code to the configuration module if you want to add some defaults based on user-provided values or other external conditions. We don't have the devnotes for `ConfigurationModule` at all. 2. Yes, we do. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
