zstan commented on code in PR #2690:
URL: https://github.com/apache/ignite-3/pull/2690#discussion_r1363759097
##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItDataTypesTest.java:
##########
@@ -322,7 +322,7 @@ public void testDecimalLiteral() {
"SELECT DECIMAL '0.09' BETWEEN DECIMAL '0.06' AND DECIMAL
'0.07'")
.returns(false).check();
- assertQuery("SELECT ROUND(DECIMAL '10.000', 2)").returns(new
BigDecimal("10.00")).check();
+ assertQuery("SELECT ROUND(DECIMAL '10.000', 2)").returns(new
BigDecimal("10.000")).check();
Review Comment:
probably we need to add more accurate test:
assertQuery("SELECT TYPEOF(ROUND(DECIMAL '10.000', 2))").returns("DECIMAL(5,
3)").check();
wdyt ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
