lowka commented on code in PR #2690:
URL: https://github.com/apache/ignite-3/pull/2690#discussion_r1364924163
##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItDataTypesTest.java:
##########
@@ -322,7 +322,7 @@ public void testDecimalLiteral() {
"SELECT DECIMAL '0.09' BETWEEN DECIMAL '0.06' AND DECIMAL
'0.07'")
.returns(false).check();
- assertQuery("SELECT ROUND(DECIMAL '10.000', 2)").returns(new
BigDecimal("10.00")).check();
+ assertQuery("SELECT ROUND(DECIMAL '10.000', 2)").returns(new
BigDecimal("10.000")).check();
Review Comment:
This PR adds test cases for ROUND function to `ItFunctionsTest`. Test cases
with return type assertions can be found there.
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/exp/RexImpTable.java:
##########
@@ -632,7 +632,7 @@ Builder populate() {
defineMethod(DEGREES, "degrees", NullPolicy.STRICT);
defineMethod(POW, "power", NullPolicy.STRICT);
defineMethod(RADIANS, "radians", NullPolicy.STRICT);
- defineMethod(ROUND, "sround", NullPolicy.STRICT);
+ defineIgniteMethod(ROUND, "sround", NullPolicy.STRICT);
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
