lowka commented on code in PR #2690:
URL: https://github.com/apache/ignite-3/pull/2690#discussion_r1364296401
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/exp/RexImpTable.java:
##########
@@ -4359,6 +4364,26 @@ private static class DefaultImplementor extends
AbstractRexCallImplementor {
}
}
+ private static class IgniteMethodNameImplementor extends
AbstractRexCallImplementor {
Review Comment:
Because `defineMethod` one expects that all methods are defined on calcite's
`SqlFunctions`. (1)
And it is not possible to define a method with multiple overloads in
`IgniteSqlFunctions`. (2)
The second one can be fixed if we to allow defining functions by name w/o
specifying their signatures e.g. ROUND function would look like:
> ROUND("round");
This would also required adding methodName to `IgniteSqlFunctions`
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/exp/RexImpTable.java:
##########
@@ -4359,6 +4364,26 @@ private static class DefaultImplementor extends
AbstractRexCallImplementor {
}
}
+ private static class IgniteMethodNameImplementor extends
AbstractRexCallImplementor {
Review Comment:
Because `defineMethod` expects that all methods are defined on calcite's
`SqlFunctions`. (1)
And it is not possible to define a method with multiple overloads in
`IgniteSqlFunctions`. (2)
The second one can be fixed if we to allow defining functions by name w/o
specifying their signatures e.g. ROUND function would look like:
> ROUND("round");
This would also required adding methodName to `IgniteSqlFunctions`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
