sanpwc commented on code in PR #2792:
URL: https://github.com/apache/ignite-3/pull/2792#discussion_r1381629742
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -964,23 +967,30 @@ public void stop() {
metaStorageMgr.unregisterWatch(stableAssignmentsRebalanceListener);
metaStorageMgr.unregisterWatch(assignmentsSwitchRebalanceListener);
- Map<Integer, TableImpl> tablesToStop =
Stream.concat(latestTablesById().entrySet().stream(),
pendingTables.entrySet().stream())
- .collect(Collectors.toMap(Map.Entry::getKey,
Map.Entry::getValue, (v1, v2) -> v1));
+ var tablesToStop = new HashMap<Integer, TableImpl>();
+
+ tablesToStop.putAll(latestTablesById());
+ tablesToStop.putAll(pendingTables);
cleanUpTablesResources(tablesToStop);
+ }
- try {
- IgniteUtils.closeAllManually(lowWatermark, mvGc);
- } catch (Throwable t) {
- LOG.error("Failed to close internal components", t);
+ @Override
+ public void stop() throws Exception {
Review Comment:
I almost sure that in some tests we may just call stop instead of proper
chain of beforeNodeStop + stop. I'd add corresponding assertion that
beforeStopGuard is true here in order to check (and fix) the guess.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
