sanpwc commented on code in PR #2792:
URL: https://github.com/apache/ignite-3/pull/2792#discussion_r1381646666
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -964,23 +967,30 @@ public void stop() {
metaStorageMgr.unregisterWatch(stableAssignmentsRebalanceListener);
Review Comment:
beforeNodeStop was added in order to have an ability to finish some actions
that require local network layer to be up and running.
Why do we call e.g. metaStorageMgr.unregisterWatch() within beforeNodeStop?
Does it really need a network? Or it should go before some other action that
requires network or ...? It's also about stopping tables. Does it required a
network?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
