sanpwc commented on code in PR #2792:
URL: https://github.com/apache/ignite-3/pull/2792#discussion_r1381720488
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -964,23 +967,30 @@ public void stop() {
metaStorageMgr.unregisterWatch(stableAssignmentsRebalanceListener);
Review Comment:
> I've put these calls here, so that meta storage watches would be disabled
when we are calling stop. Does it make sense?
That doesn't matter, but because ms.unregister should go before replica.stop
and replica stop do require network, proposed order and localization seems
reasonable.
> For tables - yes, we need the network. This is what the original problem
of this ticket was about: when we call TableManager#stop we also call
Replica#shutdown which does a network call (which never succeeds). That's why I
moved the whole cleanupTableResources to beforeNodeStop.
Sounds reasonable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
