sashapolo commented on code in PR #2792:
URL: https://github.com/apache/ignite-3/pull/2792#discussion_r1381694573
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -964,23 +967,30 @@ public void stop() {
metaStorageMgr.unregisterWatch(stableAssignmentsRebalanceListener);
Review Comment:
> Why do we call e.g. metaStorageMgr.unregisterWatch() within
beforeNodeStop? Does it really need a network?
I've put these calls here, so that meta storage watches would be disabled
when we are calling `stop`. Does it make sense?
> It's also about stopping tables. Does it required a network?
For tables - yes, we need the network. This is what the original problem of
this ticket was about: when we call `TableManager#stop` we also call
`Replica#shutdown` which does a network call (which never succeeds). That's why
I moved the whole `cleanupTableResources` to `beforeNodeStop`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
