lowka commented on code in PR #2786:
URL: https://github.com/apache/ignite-3/pull/2786#discussion_r1390667011
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/IgniteTypeCoercion.java:
##########
@@ -271,6 +271,12 @@ protected boolean needToCast(SqlValidatorScope scope,
SqlNode node, RelDataType
if (fromType == null) {
return false;
}
+
+ if (fromType.getSqlTypeName() == SqlTypeName.BIGINT &&
toType.getSqlTypeName() == SqlTypeName.BIGINT) {
Review Comment:
It more or less looks like an attempt to fix BIGINTs for scalar subqueries
in DML statements. But it is not correct (see the next comment on cast from
`ROW` type).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
