zstan commented on code in PR #2786:
URL: https://github.com/apache/ignite-3/pull/2786#discussion_r1392050179
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/IgniteSqlValidator.java:
##########
@@ -178,6 +194,33 @@ public void validateUpdate(SqlUpdate call) {
syncSelectList(select, call);
}
+ /** {@inheritDoc} */
+ @Override
+ protected void checkTypeAssignment(
+ SqlValidatorScope sourceScope,
+ SqlValidatorTable table,
+ RelDataType sourceRowType,
+ RelDataType targetRowType,
+ SqlNode query
+ ) {
+ boolean coerced = false;
+
+ if (config().typeCoercionEnabled()) {
+ if (SqlTypeUtil.equalAsStructSansNullability(typeFactory,
Review Comment:
removing of this part leads to testInsertValueOverflow failure, something
wrong with Idea caching or rebuilding, first run of such a test with commented
lines gives me correct tests passing but second is already not, the same for
IgniteSqlToRelConvertor part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
