korlov42 commented on code in PR #2786:
URL: https://github.com/apache/ignite-3/pull/2786#discussion_r1395502173
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/IgniteSqlValidator.java:
##########
@@ -178,6 +194,33 @@ public void validateUpdate(SqlUpdate call) {
syncSelectList(select, call);
}
+ /** {@inheritDoc} */
+ @Override
+ protected void checkTypeAssignment(
+ SqlValidatorScope sourceScope,
+ SqlValidatorTable table,
+ RelDataType sourceRowType,
+ RelDataType targetRowType,
+ SqlNode query
+ ) {
+ boolean coerced = false;
+
+ if (config().typeCoercionEnabled()) {
+ if (SqlTypeUtil.equalAsStructSansNullability(typeFactory,
Review Comment:
this looks more like workaround rather then proper fix for BIGINT case... If
so, let's file an issue to deal with it later, and mark all such places with
TODO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
