lowka commented on code in PR #2786:
URL: https://github.com/apache/ignite-3/pull/2786#discussion_r1390784266


##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/IgniteSqlValidator.java:
##########
@@ -87,6 +95,11 @@ public class IgniteSqlValidator extends SqlValidatorImpl {
 
     private static final Set<SqlKind> HUMAN_READABLE_ALIASES_FOR;
 
+    public static final String NUMERIC_FIELD_OVERFLOW_ERROR = "Numeric field 
overflow";
+
+    //approximate and exact numeric types
+    private static final Pattern numeric = 
Pattern.compile("^\\s*\\d+(\\.{1}\\d*)\\s*$");

Review Comment:
   Javacode style: `numeric` -> `NUMERIC`.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to