kgusakov commented on code in PR #4129:
URL: https://github.com/apache/ignite-3/pull/4129#discussion_r1692271794
##########
modules/raft/src/main/java/org/apache/ignite/raft/jraft/rpc/CliRequests.java:
##########
@@ -89,7 +99,8 @@ public interface ChangePeersAsyncRequest extends Message {
Collection<String> newLearnersList();
- long term();
+ // term is intentionally Long and not long in order to perform
nullable (not initialized) check.
Review Comment:
I'm sorry, didn't understand - it is not mandatory (not @Nullable), but can
be null at the same time?
##########
modules/raft/src/main/java/org/apache/ignite/internal/raft/RaftGroupServiceImpl.java:
##########
@@ -314,21 +314,29 @@ public CompletableFuture<Void> removePeer(Peer peer) {
}
@Override
- public CompletableFuture<Void> changePeers(Collection<Peer> peers) {
+ public CompletableFuture<Void> changePeers(PeersAndLearners
peersAndLearners, long term) {
Review Comment:
So, changePeers now change peers and learners actually, it's confusing a
little bit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
