alievmirza commented on code in PR #4129:
URL: https://github.com/apache/ignite-3/pull/4129#discussion_r1692677419
##########
modules/raft/src/main/java/org/apache/ignite/raft/jraft/Node.java:
##########
@@ -178,18 +178,19 @@ public interface Node extends Lifecycle<NodeOptions>,
Describer {
* Change the configuration of the raft group to |newPeers| , done.run()
would be invoked after this operation
* finishes, describing the detailed result.
*
- * @param newPeers new peers to change
+ * @param newPeersAndLearners new peers and learners to change
+ * @param term term on which this method was called. If real raft group
term will be different - changePeers will be skipped.
* @param done callback
*/
- void changePeers(final Configuration newPeers, final Closure done);
+ void changePeers(final Configuration newPeersAndLearners, long term, final
Closure done);
Review Comment:
Params differ from `void changePeersAsync(final Configuration newConf,`. I
would expect the same naming for both two methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
