sanpwc commented on code in PR #4129:
URL: https://github.com/apache/ignite-3/pull/4129#discussion_r1692587434
##########
modules/raft/src/main/java/org/apache/ignite/internal/raft/RaftGroupServiceImpl.java:
##########
@@ -314,21 +314,29 @@ public CompletableFuture<Void> removePeer(Peer peer) {
}
@Override
- public CompletableFuture<Void> changePeers(Collection<Peer> peers) {
+ public CompletableFuture<Void> changePeers(PeersAndLearners
peersAndLearners, long term) {
Review Comment:
Yep, just like changePeersAsync that also changes both peers and learners.
Do you believe that I should rename both?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
