sanpwc commented on code in PR #4129:
URL: https://github.com/apache/ignite-3/pull/4129#discussion_r1692589861
##########
modules/raft/src/main/java/org/apache/ignite/raft/jraft/rpc/CliRequests.java:
##########
@@ -89,7 +99,8 @@ public interface ChangePeersAsyncRequest extends Message {
Collection<String> newLearnersList();
- long term();
+ // term is intentionally Long and not long in order to perform
nullable (not initialized) check.
Review Comment:
It's mandatory because it's not marked as @Nullable. If someone will forget
to specify term() while building the request AssertionError will be thrown,
something like "request field not marked with @nullable has null value".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
