pan3793 commented on PR #4698: URL: https://github.com/apache/kyuubi/pull/4698#issuecomment-1508531926
> It's a default implementation created by helm create chart_name. What does the "default" mean? - the labels - the `_helpers.tpl` I'm +0 for centralizing the labels into `_helpers.tpl`, the major reason is to reduce redundant codes, but given the reason listed by @dnskr, this may be kind of an over-engineering change. Another thing, `kyuubi.common.labels` is not a good name, which is too "common", unless it is a common practice in Helm charts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
