pan3793 commented on code in PR #4698: URL: https://github.com/apache/kyuubi/pull/4698#discussion_r1167061453
########## charts/kyuubi/templates/_helpers.tpl: ########## @@ -31,3 +31,21 @@ For details, see 'kyuubi.frontend.protocols': https://kyuubi.readthedocs.io/en/m {{- end }} {{- $protocols | join "," }} {{- end }} + +{{/* +Generate kyuubi common labels. Review Comment: the code is short and clear, the comment should explain the purpose of the definition instead of what the code does. Labels used by selectors to match Kyuubi resources. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
