dev-lpq commented on PR #4698: URL: https://github.com/apache/kyuubi/pull/4698#issuecomment-1508790822
> * It's less clear and readable: template renders template which also renders template @dnskr @pan3793 Thanks for your review and answer. But as the helm official doc, `_helpers.tpl` : A place to put template helpers that you can re-use throughout the char. There is no doubt that Kyuubi labels are re-used in char. https://helm.sh/docs/chart_template_guide/getting_started/#a-quick-glimpse-of-mycharttemplates in my view： 1. Follow the helm official doc, and define re-used labels in the _helpers.tpl that make Yaml cleaner and easy to read. 2. Don't worry about indents formatted, I think that defining helm labels helps manage Yaml indents formatted. 4. Label info is relatively fixed and is frequently used in templates, so there is no impact on the developer when jumping between templates and helpers.tpl @pan3793 I change the name from kyuubi.common.labels to kyuubi.selectorLabels by viewing other Apache repo [skywalking-kubernetes](https://github.com/apache/skywalking-kubernetes/blob/master/chart/adapter/templates/_helpers.tpl), [apisix-helm-chart](https://github.com/apache/apisix-helm-chart/blob/master/charts/apisix-dashboard/templates/_helpers.tpl). If the Kyuubi define label is an over-engineering change, please ignore it. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
