dnskr commented on PR #4698: URL: https://github.com/apache/kyuubi/pull/4698#issuecomment-1508995940
@dev-lpq BTW, [skywalking-kubernetes](https://github.com/apache/skywalking-kubernetes/tree/master/chart) charts have some problems/inconsistencies related to common labels: - [adapter](https://github.com/apache/skywalking-kubernetes/tree/master/chart/adapter) has common labels defined in _helpers.tpl, but uses them in Deployment resource only. - [operator](https://github.com/apache/skywalking-kubernetes/tree/master/chart/operator) also has common labels defined in _helpers.tpl, but uses them in Deployment resource only. - [skywalking](https://github.com/apache/skywalking-kubernetes/tree/master/chart/skywalking) uses approach with explicitly defined labels (our current implementation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
