wForget commented on PR #5217: URL: https://github.com/apache/kyuubi/pull/5217#issuecomment-1702456496
> Although creating a new Limiter on configuration updates is simpler, but still some thread-safe issues that need to be addressed in `increment` or `decrement` method? I wonder if anyone would be willing to discuss with me, or provide some guidance, so that I can complete this PR. Thanks！ We only need to set a new limiter when updating the limiter configurations and there are no thread safety problem in the `increment` and `decrement` methods because they calculate the counter with `AtomicInteger`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
