wForget commented on PR #5217: URL: https://github.com/apache/kyuubi/pull/5217#issuecomment-1702482988
@zhuyaogai I drafted the implementation steps, do you think it's feasible? + remove `SessionLimiterWithAccessControlListImpl#setUnlimitedUsers` and `SessionLimiterWithAccessControlListImpl#setDenyUsers` methods + add `KyuubiSessionManager.refreshLimiterWithConfig` method instead of `SessionLimiter.refreshUnlimitedUsers`(and `refreshDenyUsers`) to reset new limiter with new configs + call `refreshLimiterWithConfig` in `refreshUnlimitedUsers` and `refreshDenyUsers` + add `@volatile` to `KyuubiSessionManager.limiter` var (and batchLimiter) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
