wForget commented on PR #5217: URL: https://github.com/apache/kyuubi/pull/5217#issuecomment-1703989590
Let's go back to this issue. I think there are two inconsistencies, the user limit counter is not cleared when user is added to unlimited user list, and the user running sessions are not added to user limit counter when removing user from unlimited user list. I offer two solutions for this: 1. Put the limiter calculation in the session, ensure that the `inc` and `dec` calculations of limiter act on the same limiter, and then use new limiter when updating configurations (as discussed above). 2. When updating configurations, clear limiter counter or add the running session to limiter counter. This needs to be considered to ensure synchronization. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
