zhuyaogai commented on PR #5217: URL: https://github.com/apache/kyuubi/pull/5217#issuecomment-1704542054
> I'm also +0 on the initial implementation, which is practicable but also dangling in fore-and-backward side effects. It will be fine to me if any one approves this. > > My further concern about the counter mechanism is that we may have a common util for solving similar situations in mapped counters. @bowenliang123 hi, I have applied your code suggestions :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
