pan3793 commented on code in PR #7029: URL: https://github.com/apache/kyuubi/pull/7029#discussion_r2054526597
########## kyuubi-server/src/main/resources/sql/mysql/006-KYUUBI-7028.mysql.sql: ########## @@ -0,0 +1,16 @@ +SELECT '< KYUUBI-7028: Persist Kubernetes metadata into metastore' AS ' '; + +CREATE TABLE IF NOT EXISTS kubernetes_metadata( + key_id bigint PRIMARY KEY AUTO_INCREMENT COMMENT 'the auto increment key id', + identifier varchar(36) NOT NULL COMMENT 'the identifier id, which is an UUID', + context varchar(32) COMMENT 'the kubernetes context', + namespace varchar(255) COMMENT 'the kubernetes namespace', + pod_name varchar(255) NOT NULL COMMENT 'the kubernetes pod name', + app_id varchar(128) COMMENT 'the application id', + app_name mediumtext COMMENT 'the application name', + app_state varchar(32) COMMENT 'the application state', + app_error mediumtext COMMENT 'the application diagnose', Review Comment: Why name those columns `app_*`, instead of `engine_*`, as we did for `metadata` table? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org For additional commands, e-mail: notifications-h...@kyuubi.apache.org
