turboFei commented on code in PR #7029:
URL: https://github.com/apache/kyuubi/pull/7029#discussion_r2059664852
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/metadata/jdbc/JdbcDatabaseDialect.scala:
##########
@@ -27,6 +32,47 @@ class GenericDatabaseDialect extends JdbcDatabaseDialect {
}
}
-class SQLiteDatabaseDialect extends GenericDatabaseDialect {}
-class MySQLDatabaseDialect extends GenericDatabaseDialect {}
-class PostgreSQLDatabaseDialect extends GenericDatabaseDialect {}
+class SQLiteDatabaseDialect extends GenericDatabaseDialect {
+ override def insertOrReplace(
+ table: String,
+ colsToInsert: Seq[String],
+ colsToReplace: Seq[String],
+ keyCol: String): Option[String] = {
+ Some(
+ s"""
+ |INSERT OR REPLACE INTO $table (${colsToInsert.mkString(",")})
+ |VALUES (${colsToInsert.map(_ => "?").mkString(",")})
+ |""".stripMargin)
+ }
+}
+class MySQLDatabaseDialect extends GenericDatabaseDialect {
+ override def insertOrReplace(
+ table: String,
+ colsToInsert: Seq[String],
+ colsToReplace: Seq[String],
+ keyCol: String): Option[String] = {
+ Some(
+ s"""
+ |INSERT INTO $table (${colsToInsert.mkString(",")})
+ |VALUES (${colsToInsert.map(_ => "?").mkString(",")})
+ |ON DUPLICATE KEY UPDATE
+ |${colsToReplace.map(c => s"$c = VALUES($c)").mkString(",")}
+ |""".stripMargin)
+ }
+}
+class PostgreSQLDatabaseDialect extends GenericDatabaseDialect {
+ override def insertOrReplace(
+ table: String,
+ colsToInsert: Seq[String],
+ colsToReplace: Seq[String],
+ keyCol: String): Option[String] = {
+ Some(
+ s"""
+ |INSERT INTO $table (${colsToInsert.mkString(",")})
+ |VALUES (${colsToInsert.map(_ => "?").mkString(",")})
+ |ON CONFLICT ($keyCol)
+ |DO UPDATE SET
+ |${colsToReplace.map(c => s"$c = EXCLUDED.$c").mkString(",")}
Review Comment:
https://www.postgresql.org/docs/current/sql-insert.html
<img width="1604" alt="image"
src="https://github.com/user-attachments/assets/7683514c-5fe0-4797-ba5b-5cec073e2125";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For additional commands, e-mail: notifications-h...@kyuubi.apache.org
