pan3793 commented on code in PR #7029:
URL: https://github.com/apache/kyuubi/pull/7029#discussion_r2062385570
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/metadata/jdbc/JdbcDatabaseDialect.scala:
##########
@@ -19,6 +19,10 @@ package org.apache.kyuubi.server.metadata.jdbc
trait JdbcDatabaseDialect {
def limitClause(limit: Int, offset: Int): String
+ def insertOrReplace(
+ table: String,
+ cols: Seq[String],
+ keyCol: String): Option[String] = None
Review Comment:
can we have a default implementation instead of returning `Option[String]`?
Or simply leave empty default implementation as all supported RDBMSs have
dedicated dialects
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For additional commands, e-mail: notifications-h...@kyuubi.apache.org
