pan3793 commented on code in PR #7029: URL: https://github.com/apache/kyuubi/pull/7029#discussion_r2054545036
########## kyuubi-server/src/main/resources/sql/mysql/006-KYUUBI-7028.mysql.sql: ########## @@ -0,0 +1,16 @@ +SELECT '< KYUUBI-7028: Persist Kubernetes metadata into metastore' AS ' '; + +CREATE TABLE IF NOT EXISTS kubernetes_metadata( Review Comment: the `metadata` is a quite general concept, thus it cannot help the user understand what the table is for. I saw we use `appInfoStore` in the code, it's a good name, maybe the table name could be `k8s_app_info`, or `k8s_engine_info`, or `k8s_engine_info_store` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org For additional commands, e-mail: notifications-h...@kyuubi.apache.org
