stephen-webb commented on a change in pull request #14: Replace ant build with
cmake
URL: https://github.com/apache/logging-log4cxx/pull/14#discussion_r376840482
##########
File path: src/test/cpp/net/socketservertestcase.cpp
##########
@@ -478,4 +477,4 @@ LOGUNIT_CLASS(SocketServerTestCase)
const File SocketServerTestCase::TEMP("output/temp");
const File SocketServerTestCase::FILTERED("output/filtered");
-LOGUNIT_TEST_SUITE_REGISTRATION_DISABLED(SocketServerTestCase)
+LOGUNIT_TEST_SUITE_REGISTRATION(SocketServerTestCase)
Review comment:
Disabling a testcase is needed when building multiple tests into a single
executable. To run a disabled test case you then need to add it as a parameter.
The socketservertestcase excutable has only one test case so I do not think
it is appropriate to disable it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
